Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add test_reduce_sum configuration as flaky #589

Closed
wants to merge 1 commit into from
Closed

chore: add test_reduce_sum configuration as flaky #589

wants to merge 1 commit into from

Conversation

RomanBredehoft
Copy link
Collaborator

@RomanBredehoft RomanBredehoft requested a review from a team as a code owner April 4, 2024 16:27
@cla-bot cla-bot bot added the cla-signed label Apr 4, 2024
@RomanBredehoft RomanBredehoft force-pushed the chore/add_test_reduce_sum_configs_as_flaky_4357 branch from 9385d64 to 926eb4d Compare April 9, 2024 08:56
@RomanBredehoft RomanBredehoft force-pushed the chore/add_test_reduce_sum_configs_as_flaky_4357 branch from 926eb4d to 4607165 Compare April 9, 2024 09:12
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2024

Coverage passed ✅

Coverage details 

---------- coverage: platform linux, python 3.8.18-final-0 -----------
Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL    7549      0   100%

59 files skipped due to complete coverage.

@RomanBredehoft
Copy link
Collaborator Author

RomanBredehoft commented Apr 9, 2024 •
edited
Loading

it looks like the new flaky will happen a lot. I first want to make sure with CP if there's actually an issue on their side or if the test does not make much sense before merging this (cf https://zama-ai.slack.com/archives/C044G400J6N/p1712654580151599)

@RomanBredehoft RomanBredehoft marked this pull request as draft April 11, 2024 14:20
@RomanBredehoft
Copy link
Collaborator Author

actually, let's see what CP says about https://github.com/zama-ai/concrete-internal/issues/681 before putting this as a known flaky

@andrei-stoian-zama andrei-stoian-zama deleted the chore/add_test_reduce_sum_configs_as_flaky_4357 branch October 17, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfrery jfrery jfrery approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RomanBredehoft @jfrery