chore: use cp vl when circuit is CRT based

[jfrery]

closes https://github.com/zama-ai/concrete-ml-internal/issues/4393

[andrei-stoian-zama]

Looks good, just a minor doubt on whether the compiled model will always be compilable and CRT with n_bits=4. But otherwise great!

[RomanBredehoft]

I would rephrase this with :

# If the virtual library method should be used 
# For now, use the virtual library when simulating circuits that uses CRT 
# decomposition because the official simulation is too slow 
# FIXME: https://github.com/zama-ai/concrete-ml-internal/issues/4391

[jfrery]

I don't like this # If the virtual library method should be used . Feels like something else is coming to complete the sentence.

[RomanBredehoft]

as you wish, not sure what would come next though. it's just that we use this formulation in most of our docstrings . We do also use whether but it usually needs to be followed by or not afterwards, which I always find a bit redundant

[jfrery]

But it's a bit weird to have:

# If the virtual library method should be used 
if USE_OLD_VL:

no? I would expect:

# If USE_OLD_VL is True, use the virtual library
if USE_OLD_VL:

[jfrery]

Anyway back to the original comment with some of your suggestion.

[RomanBredehoft]

thanks for this update, I would just make some things a bit more clear !

[andrei-stoian-zama]

This also closes https://github.com/zama-ai/concrete-ml-internal/issues/4391 right ?

[RomanBredehoft]

great thanks !

[github-actions]

Coverage passed ✅

Coverage details

---------- coverage: platform linux, python 3.8.18-final-0 -----------
Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL    7548      0   100%

59 files skipped due to complete coverage.

[RomanBredehoft]

no @andrei-stoian-zama because the issue you link is used as a fixme, until this is somehow fixed by concrete