fix: bad symlink and add checks #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcm-at-zama
reviewed
Apr 22, 2024
| @@ -844,3 +844,12 @@ run_all_use_case_examples: | |||
| .PHONY: check_utils_use_case # Check that no utils.py are found in use_case_examples | |||
| check_utils_use_case: | |||
| ./script/make_utils/check_utils_in_use_case.sh | |||
|
|
|||
| .PHONY: check_symlinks # Check that no utils.py are found in use_case_examples | |||
| check_symlinks: | |||
There was a problem hiding this comment.
needs to be added in the CI or as a sub target of something we already launch, no?
There was a problem hiding this comment.
could be done in the - name: Check links step
Closed
RomanBredehoft
previously approved these changes
Apr 22, 2024
andrei-stoian-zama
force-pushed
the
chore/check_symlinks_work
branch
from
4a09ce8 to
d4cdc47
Compare
RomanBredehoft
approved these changes
Apr 22, 2024
andrei-stoian-zama
force-pushed
the
chore/check_symlinks_work
branch
from
d4cdc47 to
e9a64d9
Compare
Coverage passed ✅Coverage details
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With many thanks to https://github.com/sukrucildirr for finding the bad symlink
Refs: #633