Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: identify ConstantOfShape ONNX nodes as constant values #641

Closed

Conversation

RomanBredehoft
Copy link
Collaborator

@RomanBredehoft RomanBredehoft commented Apr 23, 2024

this PR is in draft until we find a proper solution, as the initial suggestion is not right (ConstantOfShape are not real constants, they have an input coming in)

a model that contains a "ConstantOfShape" node can trigger an obscure AttributeError: 'RawOpOutput' object has no attribute 'quantizer' in the QuantizedAdd operator

closes https://github.com/zama-ai/concrete-ml-internal/issues/4406

@RomanBredehoft RomanBredehoft requested a review from a team as a code owner April 23, 2024 09:48
@cla-bot cla-bot bot added the cla-signed label Apr 23, 2024
Copy link
Collaborator

@andrei-stoian-zama andrei-stoian-zama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done

Copy link

Coverage failed ❌

Coverage details

---------- coverage: platform linux, python 3.8.18-final-0 -----------
Name                                                Stmts   Miss  Cover   Missing
---------------------------------------------------------------------------------
src/concrete/ml/onnx/ops_impl.py                      357      5    99%   88, 1552, 2060, 2065-2066
src/concrete/ml/quantization/base_quantized_op.py     303      1    99%   657
---------------------------------------------------------------------------------
TOTAL                                                7522      6    99%

57 files skipped due to complete coverage.

@RomanBredehoft RomanBredehoft marked this pull request as draft April 23, 2024 14:13
@RomanBredehoft
Copy link
Collaborator Author

unfortunately, the issue started to be more complex than I initially thought, and the solution provided does not entirely fix the issue : https://github.com/zama-ai/concrete-ml-internal/issues/4413

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants