Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug in llm gpt-2 demo where simulate where not called properly causing a crash in the code because operation wasn't suported #650

Closed
wants to merge 2 commits into from

Conversation

HugoLB0 added 2 commits April 25, 2024 03:45
fixed bug in use_cases_examples/llm/qgpt2_class.py demo where simulate where not called properly.
it raised error "TypeError: unsupported operand type(s) for /: 'method' and 'int'" because the <bound method Circuit.simulate> was not called properly, the parameter q_x was missing.
@HugoLB0 HugoLB0 requested a review from a team as a code owner April 25, 2024 01:50
Copy link

cla-bot bot commented Apr 25, 2024

Thank you for your pull request. We require contributors to sign our Contributor License Agreement / Terms and Conditions, and we don't seem to have the users @HugoLB0 on file. In order for us to review and merge your code, please sign:

  • For individual contribution: our CLA
  • for Bounty submission, if you are an individual: our T&C
  • for Bounty submission, if you are a company: our T&C
    to get yourself added.

If you already signed one of this document, just wait to be added to the bot config.

@fd0r
Copy link
Collaborator

fd0r commented Apr 25, 2024

Thanks a lot for catching and solving this issue @HugoLB0 !
I'll squash and re-word your changes so that the CI can run.

@fd0r
Copy link
Collaborator

fd0r commented Apr 25, 2024

Superseded by #651

@fd0r fd0r closed this Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants