docs: update documentation on client / server API #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomanBredehoft
requested changes
May 2, 2024
jfrery
force-pushed
the
docs/add_client_server_api_documentation
branch
from
070b67d to
b6d5c85
Compare
| client.generate_private_and_evaluation_keys() | ||
| # Get the serialized evaluation keys | ||
| serialized_evaluation_keys = client.get_serialized_evaluation_keys() | ||
| serialized_evaluation_keys = client.generate_private_and_evaluation_keys() |
There was a problem hiding this comment.
I was thinking more the other way 😅 like keep serialized_evaluation_keys = client.get_serialized_evaluation_keys() but include self.generate_private_and_evaluation_keys() in get_serialized_evaluation_keys
or then have a new method called "generate_keys_and_get_serialized_evaluation_keys` or similar
but that was more of an idea, we could make it an issue and consider it later if you prefer
There was a problem hiding this comment.
Yeah actually it makes more sense the way you describe. Will update.
jfrery
force-pushed
the
docs/add_client_server_api_documentation
branch
from
b6d5c85 to
671045c
Compare
| "\n", | ||
| "# Get the serialized evaluation keys\n", | ||
| "serialized_evaluation_keys = fhemodel_client.get_serialized_evaluation_keys()" | ||
| "serialized_evaluation_keys = fhemodel_client.generate_private_and_evaluation_keys()" |
There was a problem hiding this comment.
this line should still use get_serialized_evaluation_keys
There was a problem hiding this comment.
Good catch. updated.
RomanBredehoft
requested changes
May 21, 2024
jfrery
force-pushed
the
docs/add_client_server_api_documentation
branch
from
9fbc831 to
c004669
Compare
Coverage passed ✅Coverage details
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes https://github.com/zama-ai/concrete-ml-internal/issues/4430