chore: add slack alert when stopping EC2 instances fails in CI #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomanBredehoft
force-pushed
the
chore/add_slack_report_stop_ec2_failure
branch
from
81a65c8 to
1f33d46
Compare
RomanBredehoft
force-pushed
the
chore/add_slack_report_stop_ec2_failure
branch
from
269d23d to
cc32d3f
Compare
fd0r
approved these changes
Jun 13, 2024
|
@fd0r I tried to tag machinelearning but was not able to : https://zama-ai.slack.com/archives/C01022E8SRJ/p1718195645050339 currently, it tags the slack whole channel where these notifications are sent, like here : https://zama-ai.slack.com/archives/C02RX6CF3FV/p1718269669499519 are you saying you would prefer to have this notification in the main channel ? in that case I think we need another webhook and maybe other things, so might take a few more extra steps to do so |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last weekly CI failed for an unknown reason (internal error from GitHub), letting some EC2 instances running (which required to be manually terminated): https://github.com/zama-ai/concrete-ml/actions/runs/9468836256
this PR adds a slack alerts that will better warn us about such an issue cc @fd0r