Doc language edits - Part 1 #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuxizama
force-pushed
the
language-edit-1
branch
from
9a694bd to
80aa503
Compare
andrei-stoian-zama
requested changes
Jun 14, 2024
There was a problem hiding this comment.
Thanks a lot @yuxizama , just a few suggestions, some based on recent functionality updates
yuxizama
commented
Jun 14, 2024
Co-authored-by: Andrei Stoian <[email protected]>
Co-authored-by: Andrei Stoian <[email protected]>
Co-authored-by: Andrei Stoian <[email protected]>
andrei-stoian-zama
force-pushed
the
language-edit-1
branch
from
8dc4b4a to
e8fc22f
Compare
andrei-stoian-zama
previously approved these changes
Jun 17, 2024
RomanBredehoft
approved these changes
Jun 17, 2024
andrei-stoian-zama
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey team,
I've read through the first 2 parts of doc and suggested some changes to improve readability.
Plus, can you add a simple definition of PBS in the "concepts" part? It is referred several times in the "Build-in models" section without any explanation.
Thanks!