Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: faster rounding test in weekly #957

Merged
merged 4 commits into from
Dec 11, 2024
Merged

fix: faster rounding test in weekly #957

merged 4 commits into from
Dec 11, 2024

Conversation

andrei-stoian-zama
Copy link
Collaborator

Speed up the weekly test for rounding consistency

@andrei-stoian-zama andrei-stoian-zama requested a review from a team as a code owner December 9, 2024 20:30
@cla-bot cla-bot bot added the cla-signed label Dec 9, 2024
jfrery
jfrery reviewed Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@jfrery jfrery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove the FHE run here. This test is probably one of the last running crt PBS which is taking very long.

@andrei-stoian-zama andrei-stoian-zama merged commit 5b9466c into main Dec 11, 2024
24 of 25 checks passed
@andrei-stoian-zama andrei-stoian-zama deleted the fix/faster_weekly branch December 11, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfrery jfrery jfrery left review comments

@kcelia kcelia kcelia approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrei-stoian-zama @jfrery @kcelia