Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): Fix actionlint #1137

Merged
merged 1 commit into from
Nov 14, 2024
Merged

chore(ci): Fix actionlint #1137

merged 1 commit into from
Nov 14, 2024

Conversation

BourgerieQuentin
Copy link
Member

workerB

@cla-bot cla-bot bot added the cla-signed label Nov 12, 2024
github-actions[bot]
github-actions bot reviewed Nov 12, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 4a7b2f1 Previous: 20d03d4 Ratio
v0 PBS table generation 61179629 ns/iter (± 508967) 61192015 ns/iter (± 1886443) 1.00
v0 PBS simulate dag table generation 39987086 ns/iter (± 417045) 39399560 ns/iter (± 336788) 1.01
v0 WoP-PBS table generation 54144780 ns/iter (± 4216731) 53914770 ns/iter (± 459195) 1.00

This comment was automatically generated by workflow using github-action-benchmark.

@BourgerieQuentin BourgerieQuentin force-pushed the fix-actionlint branch 3 times, most recently from 3fb8584 to a614d45 Compare November 13, 2024 10:31
youben11
youben11 approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@youben11 youben11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it works, then it's good to merge :). I have some minor comments (feel free to ignore)

.github/workflows/concrete_python_benchmark.yml Show resolved Hide resolved
.github/workflows/concrete_python_finalize_release.yml Outdated Show resolved Hide resolved
.github/workflows/concrete_python_release_cpu.yml Outdated Show resolved Hide resolved
.github/workflows/concrete_python_release_cpu.yml Outdated Show resolved Hide resolved
.github/workflows/concrete_python_release_cpu.yml Outdated Show resolved Hide resolved
soonum
soonum reviewed Nov 13, 2024
View reviewed changes
Copy link
Contributor

@soonum soonum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice usage of workflow composition. Will definitely use this paradigm in tfhe-rs.

.github/workflows/concrete_python_release_cpu.yml Show resolved Hide resolved
.github/workflows/concrete_python_test_macos.yml Outdated Show resolved Hide resolved
@BourgerieQuentin BourgerieQuentin merged commit 1b2d1d2 into main Nov 14, 2024
22 of 24 checks passed
@BourgerieQuentin BourgerieQuentin deleted the fix-actionlint branch November 14, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@soonum soonum soonum left review comments

@youben11 youben11 youben11 approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BourgerieQuentin @youben11 @soonum