Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc/restrictions #1150

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Doc/restrictions #1150

wants to merge 1 commit into from

Conversation

aPere3
Copy link
Collaborator

@aPere3 aPere3 commented Nov 18, 2024

No description provided.

@cla-bot cla-bot bot added the cla-signed label Nov 18, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: ca3fb40 Previous: 87b9f0e Ratio
v0 PBS table generation 61789832 ns/iter (± 820892) 61613628 ns/iter (± 294876) 1.00
v0 PBS simulate dag table generation 39702895 ns/iter (± 376924) 39150973 ns/iter (± 535820) 1.01
v0 WoP-PBS table generation 52363948 ns/iter (± 1928283) 52288912 ns/iter (± 374626) 1.00

This comment was automatically generated by workflow using github-action-benchmark.

@BourgerieQuentin BourgerieQuentin changed the base branch from main to alex/optimizer_keyset_generation November 19, 2024 16:39
@aPere3 aPere3 force-pushed the alex/optimizer_keyset_generation branch 4 times, most recently from 655172d to af46cf4 Compare November 22, 2024 09:28
Base automatically changed from alex/optimizer_keyset_generation to main December 2, 2024 10:01

Concrete provides a way to ensure that a compilation is going to yield compatible crypto-parameters, thanks to _restrictions_. Restrictions are going to restrict the search-space walked by the optimizer to ensure that only compatible parameters can be returnedyielded. As of now, we support two major restrictions:

+ __Keyset restriction__ : Restricts the crypto-parameters to an existing keyset. This restriction is suited for users that already have a module in production, and want to compile a compatible module.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't mention use-case here IMO, above all the second one as it's really hacky to have an other hardware

keyset_restriction=restriction
)
restricted_keyset_info = restricted_module.keys.specs.program_info.get_keyset_info()
assert big_keyset_info == restricted_keyset_info
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add a reuse of a keyset generated from the Big module into the Small one.

@BourgerieQuentin
Copy link
Member

Let's wait a review from @yuxizama

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants