Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(common): add 132 bits security curves #1174

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

aPere3
Copy link
Collaborator

@aPere3 aPere3 commented Dec 9, 2024

No description provided.

@cla-bot cla-bot bot added the cla-signed label Dec 9, 2024
@aPere3 aPere3 force-pushed the alex/update_security_curves branch from 68a0ed9 to a10754b Compare December 9, 2024 13:25
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 4d6afba Previous: 6d96a08 Ratio
v0 PBS table generation 61206032 ns/iter (± 915254) 61325840 ns/iter (± 1133511) 1.00
v0 PBS simulate dag table generation 39067802 ns/iter (± 517224) 38875428 ns/iter (± 1008324) 1.00
v0 WoP-PBS table generation 53923124 ns/iter (± 503951) 54226438 ns/iter (± 988211) 0.99

This comment was automatically generated by workflow using github-action-benchmark.

@aPere3 aPere3 requested a review from bencrts December 9, 2024 13:39
Copy link
Member

@BourgerieQuentin BourgerieQuentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add at least a high level (concrete-python) test to check if the option is taken into account

Copy link
Member

@bencrts bencrts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aPere3 aPere3 force-pushed the alex/update_security_curves branch 2 times, most recently from 4eff1d1 to 6d96a08 Compare December 16, 2024 09:19
@aPere3 aPere3 force-pushed the alex/update_security_curves branch from 6d96a08 to 4d6afba Compare December 16, 2024 10:24
@BourgerieQuentin BourgerieQuentin merged commit e00ccea into main Dec 16, 2024
32 of 35 checks passed
@BourgerieQuentin BourgerieQuentin deleted the alex/update_security_curves branch December 16, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants