feat(frontend): extend bridge to work with Client #1236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youben11
force-pushed
the
tfhers-bridge-with-circuitinfo
branch
2 times, most recently
from
c6411b2 to
f6db47f
Compare
this is needed in a deployment usecase where we don't have a circuit or module
youben11
force-pushed
the
tfhers-bridge-with-circuitinfo
branch
from
f6db47f to
76ebd79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The serialization format for ClientSpec has changed and isn't backward compatible. @BourgerieQuentin do you think it's worth adding checks for older version and using old format in that case? I think we would have to bump MAJOR if we don't add checks and make it backward compatible.
EDIT:
Switched to a serialization that consider programinfo as Json so we embed tfhers_specs within it. This should be backward compatible.