fix: woppbs, full cost, missing ks and hybrid packing ep #642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rudy-6-4
force-pushed
the
fix/optimizer-woppbs
branch
from
11bafeb to
5a9ee8c
Compare
|
could explain the high error rate seen in some crt tests? |
No it only change the cost, so p-error noise is not changed. |
rudy-6-4
force-pushed
the
fix/optimizer-woppbs
branch
from
5a9ee8c to
e9934d7
Compare
BourgerieQuentin
approved these changes
Jan 8, 2024
samcrx
requested changes
Mar 14, 2024
compilers/concrete-optimizer/concrete-optimizer/src/optimization/wop_atomic_pattern/optimize.rs
Outdated
Show resolved
Hide resolved
|
any updates? |
rudy-6-4
force-pushed
the
fix/optimizer-woppbs
branch
from
e9934d7 to
3dfca30
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark
| Benchmark suite | Current: 3dfca30 | Previous: d033102 | Ratio |
|---|---|---|---|
v0 PBS table generation |
65532451 ns/iter (± 1561780) |
58361887 ns/iter (± 440478) |
1.12 |
v0 PBS simulate dag table generation |
38991806 ns/iter (± 394127) |
40843995 ns/iter (± 247574) |
0.95 |
v0 WoP-PBS table generation |
68349274 ns/iter (± 2155234) |
68103504 ns/iter (± 2622284) |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
samcrx
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.