Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(frontend): add documentation for fhe modules #764

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

aPere3
Copy link
Collaborator

@aPere3 aPere3 commented Mar 28, 2024

No description provided.

@cla-bot cla-bot bot added the cla-signed label Mar 28, 2024
@aPere3 aPere3 force-pushed the doc/multi-function branch from 1c73b61 to 38b4eec Compare March 28, 2024 09:29
Copy link
Member

@BourgerieQuentin BourgerieQuentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for v0, let's see to improve when we will deliver the final version

@BourgerieQuentin
Copy link
Member

maybe @yuxizama you may have a look?

Copy link
Contributor

@yuxizama yuxizama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I did some language audit on the texts to improve the readability.
Feel free to correct if there's any error :)

docs/compilation/modules.md Outdated Show resolved Hide resolved
docs/compilation/modules.md Outdated Show resolved Hide resolved
docs/compilation/modules.md Outdated Show resolved Hide resolved
docs/guides/deploy.md Outdated Show resolved Hide resolved
docs/guides/deploy.md Outdated Show resolved Hide resolved
docs/guides/deploy.md Outdated Show resolved Hide resolved
@aPere3
Copy link
Collaborator Author

aPere3 commented Apr 2, 2024

Hello @yuxizama ! Thanks for having a look on such a short notice. I addressed all you comment but one, where I proposed another formulation. Tell me if the changes suit you, in which case, you can probably approve the PR ! Best.

docs/guides/deploy.md Outdated Show resolved Hide resolved
Copy link
Contributor

@yuxizama yuxizama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@BourgerieQuentin BourgerieQuentin merged commit 2eae071 into main Apr 4, 2024
23 checks passed
@BourgerieQuentin BourgerieQuentin deleted the doc/multi-function branch April 4, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants