feat(frontend): warn if aes cpu flag isn't available #770
Conversation
| from cpuinfo import get_cpu_info | ||
|
|
||
| def _is_cpu_compatible() -> bool: | ||
| """Check if CPU can run Concrete |
There was a problem hiding this comment.
maybe
CPU has AES instruction
they can still run compilation ?
There was a problem hiding this comment.
Still not sure to check for aes only
There was a problem hiding this comment.
aes is not actually an issue I guess, as we fallback to a software implementation
| bool: if the CPU does support required features to run Concrete | ||
| """ | ||
| flags = get_cpu_info()["flags"] | ||
| if "aes" in flags: |
| return False | ||
|
|
||
| # Print a warning if the CPU can't run Concrete | ||
| if not _is_cpu_compatible(): |
There was a problem hiding this comment.
why at top level ?
can't they at least compile but not run ?
if the case, maybe the warning should be an error when calling a circuit execution.
and onluy a warning when calling compilation
There was a problem hiding this comment.
The idea is to show a warning whenever you import concrete. It take some time to run so I'm not sure about adding it as part of the execution call
|
I don't known what todo with that PR... Here we check for aes instruction, but that should not be a issue, actually I'm not sure what instructions is actually needed and if it is actually needed to check all of them.. |
|
I think we already decided to close this one, but I haven't done it yet |
No description provided.