Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(frontend-python): update black dev dependency #798

Merged
merged 1 commit into from
May 22, 2024
Merged

chore(frontend-python): update black dev dependency #798

merged 1 commit into from
May 22, 2024

Conversation

aquint-zama
Copy link
Contributor

No description provided.

@cla-bot cla-bot bot added the cla-signed label Apr 19, 2024
@aquint-zama aquint-zama force-pushed the dependabot/update-black branch from 3e6e268 to 6226ece Compare April 19, 2024 15:14
umut-sahin
umut-sahin suggested changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@umut-sahin umut-sahin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing, we can't merge like this. Also, why the change?

@aquint-zama
Copy link
Contributor Author

CI is failing, we can't merge like this. Also, why the change?

for security reason, black version used has 2 vulnerabilities:
https://github.com/zama-ai/concrete/security/dependabot/17
https://github.com/zama-ai/concrete/security/dependabot/16

@umut-sahin
Copy link
Contributor

I see, then let's fix the CI and merge 👍

@aquint-zama aquint-zama force-pushed the dependabot/update-black branch from 6226ece to 1fc7f34 Compare April 30, 2024 15:37
@aquint-zama aquint-zama requested a review from umut-sahin April 30, 2024 15:51
@aquint-zama aquint-zama force-pushed the dependabot/update-black branch from 1fc7f34 to a03877c Compare April 30, 2024 15:52
@umut-sahin
Copy link
Contributor

CI seems to be broken still, with the same tests failing on each machine. It seems related to approximate, so maybe @rudy-6-4 have any ideas?

@BourgerieQuentin
Copy link
Member

Should be fixed by #812, let's finish the CI and merge then rebase PRs

@aquint-zama aquint-zama force-pushed the dependabot/update-black branch from a03877c to 8f26a73 Compare May 6, 2024 07:52
@aquint-zama aquint-zama force-pushed the dependabot/update-black branch from 8f26a73 to d185a09 Compare May 21, 2024 09:18
@aquint-zama
Copy link
Contributor Author

\o/ CI is ok cc @umut-sahin

@aquint-zama aquint-zama force-pushed the dependabot/update-black branch from d185a09 to e47d2d2 Compare May 22, 2024 09:27
@aquint-zama aquint-zama merged commit 3740d38 into main May 22, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umut-sahin umut-sahin umut-sahin approved these changes

@BourgerieQuentin BourgerieQuentin BourgerieQuentin approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aquint-zama @umut-sahin @BourgerieQuentin