fix(frontend): remove ResourceWarning from using TemporaryDirectory
#802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umut-sahin
approved these changes
Apr 24, 2024
umut-sahin
suggested changes
Apr 24, 2024
fd0r
force-pushed
the
small_temp_file_fix
branch
from
7513610 to
90971f8
Compare
We currently have something like `var = TemporaryDirectory` without explicitly calling the `close` method on `var` thus raising a `ResourceWarning` when the resource is implicitely cleaned-up. This could be avoided by using `mkdtemp` instead.
fd0r
force-pushed
the
small_temp_file_fix
branch
from
90971f8 to
da28812
Compare
|
More changes than expected but the CI is happy. It required a signature change, not sure if it's fine with you guys? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently have something like
var = TemporaryDirectorywithout explicitly calling theclosemethod onvarthus raising aResourceWarningwhen the resource is implicitely cleaned-up.This could be avoided by using
mkdtempinstead.