-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(frontend): adding a use-case for Levenshtein distance #902
Conversation
f61fa55
to
122de8c
Compare
Works quite well but fail from time to time:
I have |
c9b3afb
to
d6720e5
Compare
Now:
|
Hey @umut-sahin , would you have a look, to see if we can make it faster, please? |
frontends/concrete-python/examples/levenshtein_distance/levenshtein_distance.py
Outdated
Show resolved
Hide resolved
frontends/concrete-python/examples/levenshtein_distance/levenshtein_distance.py
Outdated
Show resolved
Hide resolved
frontends/concrete-python/examples/levenshtein_distance/levenshtein_distance.py
Outdated
Show resolved
Hide resolved
frontends/concrete-python/examples/levenshtein_distance/levenshtein_distance.py
Outdated
Show resolved
Hide resolved
0ee22ef
to
e2dceee
Compare
Now I have added a system for alphabet: eg, one can do
and you'll see it generates random string of A, C, T and G. |
It's very easy to add a new alphabet |
And there is a new option, to make perks on all alphabets:
|
What do you think guys? When you like the code, I add a small .md and measure that on AWS |
63c858e
to
1247eda
Compare
1247eda
to
2771fed
Compare
No more blocked by 794 |
frontends/concrete-python/examples/levenshtein_distance/levenshtein_distance.py
Outdated
Show resolved
Hide resolved
frontends/concrete-python/examples/levenshtein_distance/levenshtein_distance.md
Show resolved
Hide resolved
frontends/concrete-python/examples/levenshtein_distance/levenshtein_distance.py
Outdated
Show resolved
Hide resolved
frontends/concrete-python/examples/levenshtein_distance/levenshtein_distance.md
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment feel free to include or not, thanks.
frontends/concrete-python/examples/levenshtein_distance/levenshtein_distance.md
Show resolved
Hide resolved
frontends/concrete-python/examples/levenshtein_distance/levenshtein_distance.md
Show resolved
Hide resolved
@bcm-at-zama I updated the code with a constant function fell free to keep it or not, still bad as we need the "encrypt function" on server side, but is more a lack of the API that we need the client to export clear value |
Thx for 380a523 @BourgerieQuentin . I'll reapply it by hand sorry, because too much big conflicts with my coming Alphabet things. |
380a523
to
88e579e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've done an Alphabet class as requested, even if I am not a big fan. We may let some functions outside of the class, tell me what you want @umut-sahin
frontends/concrete-python/examples/levenshtein_distance/levenshtein_distance.py
Show resolved
Hide resolved
frontends/concrete-python/examples/levenshtein_distance/levenshtein_distance.py
Outdated
Show resolved
Hide resolved
frontends/concrete-python/examples/levenshtein_distance/levenshtein_distance.py
Outdated
Show resolved
Hide resolved
frontends/concrete-python/examples/levenshtein_distance/levenshtein_distance.py
Outdated
Show resolved
Hide resolved
frontends/concrete-python/examples/levenshtein_distance/levenshtein_distance.py
Outdated
Show resolved
Hide resolved
frontends/concrete-python/examples/levenshtein_distance/levenshtein_distance.py
Show resolved
Hide resolved
c0198fe
to
ac87b6e
Compare
frontends/concrete-python/examples/levenshtein_distance/levenshtein_distance.py
Show resolved
Hide resolved
frontends/concrete-python/examples/levenshtein_distance/levenshtein_distance.py
Outdated
Show resolved
Hide resolved
frontends/concrete-python/examples/levenshtein_distance/levenshtein_distance.py
Outdated
Show resolved
Hide resolved
frontends/concrete-python/examples/levenshtein_distance/levenshtein_distance.py
Outdated
Show resolved
Hide resolved
frontends/concrete-python/examples/levenshtein_distance/levenshtein_distance.py
Outdated
Show resolved
Hide resolved
frontends/concrete-python/examples/levenshtein_distance/levenshtein_distance.py
Show resolved
Hide resolved
@umut-sahin : hopefully it's the final review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small things, but it's good to merge otherwise!
frontends/concrete-python/examples/levenshtein_distance/levenshtein_distance.py
Outdated
Show resolved
Hide resolved
frontends/concrete-python/examples/levenshtein_distance/levenshtein_distance.py
Show resolved
Hide resolved
ca6e860
to
817341f
Compare
Rebasing |
@umut-sahin , perf have been done on hpc, could you tell me it's fine for you? Then I squash and merge! |
frontends/concrete-python/examples/levenshtein_distance/levenshtein_distance.md
Show resolved
Hide resolved
43350ce
to
9682493
Compare
Adding a use-case for Levenshtein distance
closes #https://github.com/zama-ai/concrete-internal/issues/750