Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(tests): support e2e tests with specific versions of deps #213

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

youben11
Copy link
Member

@youben11 youben11 commented Oct 6, 2023

workerB

Description

This PR adds the ability to run e2e tests from the action section providing specific version for geth, ethermint, and the solidity library, which will make it possible to avoid to tag specific changes and create a PR in order to be able to run e2e tests.

This also opens up the way to run e2e tests whenever there are changes in geth (could also do it for other ptojects, but geth is the main need currently).


All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

PR review checkboxes:

I have...

  • added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • included the correct type prefix in the PR title
  • targeted the correct branch (see PR Targeting)
  • provided a link in the PR description to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all required CI checks have passed

Code maintenance:

I have...

  • written unit and integration tests
  • added relevant godoc and code comments.
  • updated relevant documentation (docs/) or specification (x/<module>/spec/)

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • confirmed that this PR does not change production code

@youben11 youben11 requested a review from leventdem October 6, 2023 10:42
@cla-bot cla-bot bot added the cla-signed label Oct 6, 2023
Copy link
Collaborator

@leventdem leventdem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@youben11 youben11 merged commit 8fba234 into v9.1.0-zama Oct 10, 2023
10 checks passed
@youben11 youben11 deleted the ci/manual_e2e branch October 10, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants