Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: contract links in markdown files #90

Merged
merged 2 commits into from
Oct 30, 2024
Merged

fix: contract links in markdown files #90

merged 2 commits into from
Oct 30, 2024

Conversation

dartdart26
Copy link
Collaborator

No description provided.

@dartdart26 dartdart26 requested review from jot2re and jatZama October 30, 2024 09:58
@dartdart26 dartdart26 self-assigned this Oct 30, 2024
@dartdart26 dartdart26 merged commit 514ec6a into main Oct 30, 2024
3 checks passed
@dartdart26 dartdart26 deleted the petar/fix-links branch October 30, 2024 10:20
Copy link
Contributor

@jot2re jot2re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems some links are dead, e.g. https://github.com/zama-ai/fhevm/blob/main/lib/TFHEExecutor.sol
I am also wondering why you now linking out of the fhevm-backend repo? Wouldn’t the full path within the fhevm-backend repo be sufficient? E.g. https://github.com/zama-ai/fhevm-backend/blob/main/contracts/contracts/TFHEExecutor.sol

@dartdart26
Copy link
Collaborator Author

I linked files in fhevm-backend repo. What do you mean re fhevm?

@jot2re
Copy link
Contributor

jot2re commented Oct 30, 2024

@dartdart26 Sorry, I am clearly very tired. I read the old state as the changes and the new changes as the old state.

@dartdart26
Copy link
Collaborator Author

@dartdart26 Sorry, I am clearly very tired. I read the old state as the changes and the new changes as the old state.

No worries! I merged it to just move forward quickly. @david-zk Could you please disallow that and require at least 1 approving review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants