Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: handle the read-only flag inside OpSstore #23

Merged
merged 1 commit into from
Oct 27, 2023
Merged

feat: handle the read-only flag inside OpSstore #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions fhevm/instructions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,10 @@ func persistIfVerifiedCiphertext(flagHandleLocation common.Hash, handle common.H
env.SetState(protectedStorage, metadataKey, metadata.serialize())
}

func OpSstore(pc *uint64, env EVMEnvironment, scope ScopeContext) []byte {
func OpSstore(pc *uint64, env EVMEnvironment, scope ScopeContext) ([]byte, error) {
if env.IsReadOnly() {
return nil, ErrWriteProtection
}
loc := scope.GetStack().Pop()
locHash := common.BytesToHash(loc.Bytes())
newVal := scope.GetStack().Pop()
Expand All @@ -288,7 +291,7 @@ func OpSstore(pc *uint64, env EVMEnvironment, scope ScopeContext) []byte {
}
// Set the SSTORE's value in the actual contract.
env.SetState(scope.GetContract().Address(), loc.Bytes32(), newValHash)
return nil
return nil, nil
}

// If there are ciphertext handles in the arguments to a call, delegate them to the callee.
Expand Down