This repository has been archived by the owner on Dec 23, 2024. It is now read-only.
Readme and License #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aquint-zama
approved these changes
Jan 16, 2024
aquint-zama
reviewed
Jan 18, 2024
Integration.md
Outdated
|
|
||
| This document is a guide listing detailed steps to integrate [fhevm-go](https://github.com/zama-ai/fhevm-go) into [go-ethereum](https://github.com/ethereum/go-ethereum) or any other implementations that follows the same architecture. | ||
|
|
||
| **Note:** This document is based on go-ethereum v1.13.5 |
There was a problem hiding this comment.
Suggested change
| **Note:** This document is based on go-ethereum v1.13.5 | |
| > **Note** | |
| > This document is based on go-ethereum v1.13.5 |
There was a problem hiding this comment.
Thanks, I could use them in unindented notes, but it didn't work for indented ones so I left them as is
youben11
force-pushed
the
readme
branch
2 times, most recently
from
78e6a7c to
22a000d
Compare
dartdart26
reviewed
Jan 18, 2024
|
|
||
| ## Documentation | ||
|
|
||
| Full, comprehensive documentation is available at [https://docs.zama.ai/fhevm](https://docs.zama.ai/fhevm) (still nothing about fhevm-go however). |
There was a problem hiding this comment.
Should we remove the note about fhevm-go missing from fhevm doc?
There was a problem hiding this comment.
Yes, but not until we know what to do about the docs
dartdart26
approved these changes
Jan 18, 2024
dartdart26
approved these changes
Jan 18, 2024
Co-authored-by: Petar Ivanov <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.