Skip to content
This repository has been archived by the owner on Dec 23, 2024. It is now read-only.

Refactor TFHE #79

Merged
merged 3 commits into from
Feb 8, 2024
Merged

Refactor TFHE #79

merged 3 commits into from
Feb 8, 2024

Conversation

youben11
Copy link
Member

@youben11 youben11 commented Feb 7, 2024

No description provided.

Copy link
Contributor

@immortal-tofu immortal-tofu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work!

@@ -0,0 +1,2124 @@
#include "tfhe_wrappers.h"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related to this PR, but with so much C code, we need to add some tooling to check for memory errors/leaks.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And/or use auto-generation of the wrappers to reduce the risk of a bug.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the first point, I can look into that, and also make sure the Go build does use hardening flags during compilation maybe.

For the second point, I need to look deeper into the wrappers to see if there is anything we can automate here.

Copy link
Contributor

@dartdart26 dartdart26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@youben11 youben11 merged commit b7d5a66 into main Feb 8, 2024
2 checks passed
@youben11 youben11 deleted the refactor/tfhe branch February 8, 2024 10:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants