Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix due to change in hardhat-templates + README #642

Merged
merged 36 commits into from
Dec 11, 2024
Merged

docs: fix due to change in hardhat-templates + README #642

merged 36 commits into from
Dec 11, 2024

Conversation

poppyseedDev
Copy link
Contributor

@poppyseedDev poppyseedDev commented Dec 6, 2024 •
edited
Loading

Closes #647
Closes #641
Closes #640
Closes #643
Closes #628

@poppyseedDev poppyseedDev marked this pull request as ready for review December 10, 2024 21:45
@poppyseedDev
Copy link
Contributor Author

@jatZama could you review:

  • docs/guides/debug_decrypt.md
  • docs/guides/gas.md
  • docs/guides/trivial_encrypt.md

@poppyseedDev poppyseedDev requested a review from jatZama December 10, 2024 22:11
jatZama
jatZama requested changes Dec 11, 2024
View reviewed changes
Copy link
Member

@jatZama jatZama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put many comments

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docs/fundamentals/decryption/decrypt.md Outdated Show resolved Hide resolved
docs/getting_started/first_smart_contract.md Outdated Show resolved Hide resolved
docs/guides/gas.md Outdated Show resolved Hide resolved
docs/guides/gas.md Show resolved Hide resolved
docs/guides/gas.md Outdated Show resolved Hide resolved
docs/guides/trivial_encrypt.md Outdated Show resolved Hide resolved
docs/guides/trivial_encrypt.md Outdated Show resolved Hide resolved
jatZama
jatZama reviewed Dec 11, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
jatZama
jatZama reviewed Dec 11, 2024
View reviewed changes
docs/guides/gas.md Outdated Show resolved Hide resolved
jatZama
jatZama reviewed Dec 11, 2024
View reviewed changes
docs/guides/gas.md Outdated Show resolved Hide resolved
jatZama
jatZama reviewed Dec 11, 2024
View reviewed changes
docs/guides/gas.md Outdated Show resolved Hide resolved
yuxizama
yuxizama requested changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@yuxizama yuxizama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor details.
Please ping me again when the trivial_encrypt.md is finalized
Thx!

docs/guides/debug_decrypt.md Outdated Show resolved Hide resolved
docs/guides/debug_decrypt.md Outdated Show resolved Hide resolved
docs/guides/debug_decrypt.md Outdated Show resolved Hide resolved
docs/guides/debug_decrypt.md Outdated Show resolved Hide resolved
docs/guides/debug_decrypt.md Outdated Show resolved Hide resolved
docs/guides/gas.md Outdated Show resolved Hide resolved
docs/guides/gas.md Outdated Show resolved Hide resolved
docs/guides/gas.md Outdated Show resolved Hide resolved
docs/guides/gas.md Outdated Show resolved Hide resolved
docs/guides/gas.md Outdated Show resolved Hide resolved
jatZama
jatZama reviewed Dec 11, 2024
View reviewed changes
docs/SUMMARY.md Outdated Show resolved Hide resolved
jatZama
jatZama reviewed Dec 11, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
jatZama
jatZama reviewed Dec 11, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
jatZama and others added 2 commits December 11, 2024 21:50
@jatZama @poppyseedDev
Update README.md
72f6294 
Co-authored-by: Aurora Poppyseed <[email protected]>
@jatZama @poppyseedDev
Update docs/fundamentals/asXXoperation.md
d67afd9 
Co-authored-by: Aurora Poppyseed <[email protected]>
jatZama
jatZama reviewed Dec 11, 2024
View reviewed changes
docs/guides/gas.md Outdated Show resolved Hide resolved
@poppyseedDev poppyseedDev merged commit ad6bfac into main Dec 11, 2024
5 of 7 checks passed
@poppyseedDev poppyseedDev deleted the docs-fhevm06 branch December 11, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leventdem leventdem leventdem left review comments

@yuxizama yuxizama yuxizama approved these changes

@jatZama jatZama jatZama approved these changes

@immortal-tofu immortal-tofu immortal-tofu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@poppyseedDev @immortal-tofu @leventdem @jatZama @yuxizama