Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(output): set aws region as start mode output #11

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

soonum
Copy link
Contributor

@soonum soonum commented Feb 20, 2024

This is useful when caller workflow provides a profile for stop mode and if associated PR tends to be merged before instance teardown. In that case Slab will try to fetch the remote configuration file (slab.toml) on a reference that has vanished thus resulting in an error in Slab without terminating the instance.
Using the region as input for stop mode avoid trying to fetch slab.toml file.

This is useful when caller workflow provides a profile for stop
mode and if associated PR tends to be merged before instance
teardown. In that case Slab will try to fetch the remote
configuration file (slab.toml) on a reference that has vanished
thus resulting in an error in Slab without terminating the
instance.
Using the region as input for stop mode avoid trying to fetch
slab.toml file.
@soonum soonum requested a review from IceTDrinker February 20, 2024 08:26
@soonum soonum self-assigned this Feb 20, 2024
Copy link
Member

@IceTDrinker IceTDrinker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@soonum soonum merged commit 8562abb into main Feb 20, 2024
11 checks passed
@soonum soonum deleted the dt/fix/region_as_output branch February 20, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants