feat(slab): wait slab until async task is over #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is done to handle various timeouts configuration on spawn request in Slab. Until now the timeout was set to 15 minutes. This was fine since default spawn timeout in Slab was set to 10 minutes. However in some cases, slab backend profiles can request a longer duration before timeout. Since the asynchronous task created in Slab will eventually finish, we now simply wait for this moment.
IceTDrinker
reviewed
Jul 17, 2024
Comment on lines
+61
to
+62
| // while (true) equivalent to please ESLint | ||
| for (;;) { |
There was a problem hiding this comment.
the action can be struc forever ?
There was a problem hiding this comment.
No because the task will finish at some point. Plus in case of task fetching failure we also break.
There was a problem hiding this comment.
plus worst case it's an ubuntu instance from github that is going to spin forever
IceTDrinker
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is done to handle various timeouts configuration on spawn request in Slab. Until now the timeout was set to 15 minutes. This was fine since default spawn timeout in Slab was set to 10 minutes. However in some cases, slab backend profiles can request a longer duration before timeout.
Since the asynchronous task created in Slab will eventually finish, we now simply wait for this moment.