Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(slab): sanitize path concatenation on url #37

Merged
merged 2 commits into from
Oct 24, 2024
Merged

Conversation

soonum
Copy link
Contributor

@soonum soonum commented Oct 22, 2024

No description provided.

@soonum soonum requested a review from IceTDrinker October 22, 2024 15:59
@soonum soonum self-assigned this Oct 22, 2024
src/slab.js Outdated Show resolved Hide resolved
@IceTDrinker
Copy link
Member

Fine by me but I see failed CI jobs

@soonum soonum force-pushed the dt/fix/url_concat branch from 8ff1ed8 to b936dd1 Compare October 24, 2024 14:17
@soonum soonum force-pushed the dt/fix/url_concat branch from b936dd1 to 86c3463 Compare October 24, 2024 14:21
Copy link
Member

@IceTDrinker IceTDrinker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lesgo

@soonum soonum merged commit 801df0b into main Oct 24, 2024
12 checks passed
@soonum soonum deleted the dt/fix/url_concat branch October 24, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants