feat!: unregister runner using its unique id #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IceTDrinker
approved these changes
Nov 14, 2024
soonum
force-pushed
the
dt/feat/runner_id
branch
3 times, most recently
from
ed1dec2 to
ea9229d
Compare
BREAKING CHANGE: runner name cannot be used anymore to remove it from GitHub platform. A runner can be removed directly, through the REST API, using its ID. This change has been made to avoid Slab server to fetch all registered runners before being able to filter by name and finally find ID of the runner to remove.
soonum
force-pushed
the
dt/feat/runner_id
branch
from
ea9229d to
ab93d44
Compare
IceTDrinker
reviewed
Dec 3, 2024
Comment on lines
29
to
33
| async function stop() { | ||
| const stop_instance_response = await slab.terminateInstanceRequest( | ||
| config.input.label | ||
| config.input.runnerId | ||
| ) | ||
| await slab.waitForInstance(stop_instance_response.task_id, 'stop') |
There was a problem hiding this comment.
that's fully breaking, is that what we discussed ?
There was a problem hiding this comment.
It's fully breaking but older version of the action can still be used. It's breaking from action point of view but Slab handle the backward compatibility.
IceTDrinker
approved these changes
Dec 3, 2024
Yes you're right. I'll handle this update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: runner name cannot be used anymore to remove it from GitHub platform.
A runner can be removed directly, through the REST API, using its ID. This change has been made to avoid Slab server to fetch all registered runners before being able to filter by name and finally find ID of the runner to remove.