chore(ci): test start-stop aws instance #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soonum
force-pushed
the
dt/feat/handle_existing_instance
branch
4 times, most recently
from
4301ea9 to
639e694
Compare
soonum
force-pushed
the
dt/feat/handle_existing_instance
branch
from
639e694 to
57d3e5f
Compare
soonum
force-pushed
the
dt/feat/handle_existing_instance
branch
from
57d3e5f to
9d2409e
Compare
IceTDrinker
reviewed
Nov 19, 2024
IceTDrinker
reviewed
Nov 19, 2024
IceTDrinker
approved these changes
Nov 19, 2024
The registered_runner workflow fails, I hope this is because there is no reference of it in |
No if it has the PR trigger it means something is really failing |
|
you need to checkout before calling a workflow from a workflow at least from what I read in the logs |
soonum
force-pushed
the
dt/feat/handle_existing_instance
branch
2 times, most recently
from
2e7e428 to
0b44a29
Compare
IceTDrinker
reviewed
Nov 19, 2024
soonum
force-pushed
the
dt/feat/handle_existing_instance
branch
9 times, most recently
from
197d067 to
bba0c8f
Compare
IceTDrinker
reviewed
Nov 20, 2024
soonum
force-pushed
the
dt/feat/handle_existing_instance
branch
from
bba0c8f to
150d577
Compare
soonum
force-pushed
the
dt/feat/handle_existing_instance
branch
from
150d577 to
6ca7259
Compare
IceTDrinker
approved these changes
Nov 20, 2024
IceTDrinker
reviewed
Nov 20, 2024
| steps: | ||
| - name: Runner registered | ||
| run: | | ||
| echo "Runner name: $ {{ inputs.runner-name }}" |
There was a problem hiding this comment.
this does not echo the runner name as $ is not next to {{ you have $ {{ vs ${{
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.