feat(action): handle user cancellation #46
Conversation
soonum
force-pushed
the
dt/feat/handle_cancelation
branch
from
1cfd679 to
d583493
Compare
| if (taskName === 'start') { | ||
| await acknowledgeTaskDone(taskId) | ||
| } |
There was a problem hiding this comment.
so the process is:
ask for start -> slab starts instance, starts watchdog -> action waits for instance -> acknowledge ?
isn't there a risk of slab killing the instance before the action can aknowledge ?
There was a problem hiding this comment.
also is there a risk of aknowledging before Slab is waiting for an aknwoledge ?
There was a problem hiding this comment.
isn't there a risk of slab killing the instance before the action can aknowledge ?
Reasonably, no. The sleeping time before killing the instance is 5 minutes on Slab side, AFTER the spawn is over.
also is there a risk of aknowledging before Slab is waiting for an aknwoledge ?
No this is enforced on Slab side, you cannot acknowledge an InProgress or a Failed task (it's basically a no-op)
There was a problem hiding this comment.
is it possible for the action to acknowledge an in progress task ?
and if so, can it say "ok I acknowledged, now I do something else" and never acknowledges again, meaning slab could kill the instance ?
There was a problem hiding this comment.
Nope it's not possible to acknowledge an in progress task. The implementation imposes the acknowledge call to happen after a Done task has been received.
This is useful in start mode where one can cancel before the instance is actually ready. This way a best-effort is produced to clean up any spawned instance instead of it turning into a zombie.
soonum
force-pushed
the
dt/feat/handle_cancelation
branch
from
0376aea to
dd30ab2
Compare
|
🎉 This PR is included in version 1.4.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This is useful in start mode where one can cancel before the instance is actually ready. This way a best-effort is produced to clean up any spawned instance instead of it turning into a zombie.