Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scanpolicies: Add initial 3 standardized policies #5931

Merged
merged 1 commit into from
Nov 22, 2024
Merged

scanpolicies: Add initial 3 standardized policies #5931

merged 1 commit into from
Nov 22, 2024
+408 −4

Conversation

kingthorin
Copy link
Member

@kingthorin kingthorin commented Nov 20, 2024 •
edited
Loading

Overview

  • CHANGELOG > Added note.
  • Policies > The new policy files.
  • Help content > New help content covering the new policies.

Related Issues

N/A

Checklist

  • Update help
  • Update changelog
  • Run ./gradlew spotlessApply for code formatting
  • [na] Write tests
  • [na] Check code coverage
  • Sign-off commits
  • Squash commits
  • Use a descriptive title

@kingthorin
Copy link
Member Author

Done

@psiinon
Copy link
Member

psiinon commented Nov 21, 2024

I greped the policies and counted the rules - the totals dont agree with those in the spreadsheet, so worth double checking

@psiinon
Copy link
Member

psiinon commented Nov 21, 2024

Also just noticed that the new help pages are not in the help map / index etc

@kingthorin

This comment was marked as outdated.

Sign in to view
@kingthorin
Copy link
Member Author

I greped the policies and counted the rules - the totals dont agree with those in the spreadsheet, so worth double checking

I'll add a way to the script to check this.

@kingthorin
Copy link
Member Author

Full has more because of the persistent XSS dependencies

@kingthorin kingthorin force-pushed the policies_cd_dev branch 3 times, most recently from 47407f4 to b68fa02 Compare November 21, 2024 12:08
@kingthorin
Copy link
Member Author

That should all be addressed now

@psiinon
Copy link
Member

psiinon commented Nov 21, 2024

When the tags are implemented and deployed then the help can link to those tags, but obviously that wont work right now :)

@kingthorin kingthorin mentioned this pull request Nov 21, 2024
Merged
6 tasks
thc202
thc202 reviewed Nov 22, 2024
View reviewed changes
addOns/scanpolicies/CHANGELOG.md Outdated Show resolved Hide resolved
addOns/scanpolicies/CHANGELOG.md Outdated Show resolved Hide resolved
addOns/scanpolicies/src/main/javahelp/help/contents/policy-dev-cicd.html Outdated Show resolved Hide resolved
addOns/scanpolicies/src/main/javahelp/help/contents/policy-dev-cicd.html Show resolved Hide resolved
addOns/scanpolicies/src/main/javahelp/help/contents/policy-dev-full.html Outdated Show resolved Hide resolved
addOns/scanpolicies/src/main/javahelp/help/contents/policy-dev-std.html Outdated Show resolved Hide resolved
addOns/scanpolicies/src/main/javahelp/help/contents/scanpolicies.html Outdated Show resolved Hide resolved
addOns/scanpolicies/src/main/zapHomeFiles/policies/Dev CICD.policy Show resolved Hide resolved
@kingthorin
Copy link
Member Author

Fixed

@kingthorin
Copy link
Member Author

I think I discovered the sorting may still be wrong. Update inbound.

@kingthorin
Copy link
Member Author

Should be good now per the review comments.

@thc202
Copy link
Member

thc202 commented Nov 22, 2024

I'd have kept the name element in the same place.

@kingthorin
Copy link
Member Author

That was the cost of sorting 🙂

Lemme see what else I can do.

@thc202
Copy link
Member

thc202 commented Nov 22, 2024

Sorting by ID should not (need to) change where the name is.

@kingthorin
scanpolicies: Add initial 3 standardized policies
2dd1568 
- CHANGELOG > Added note.
- Policies > The new policy files.
- Help content > New help content covering the new policies.

Signed-off-by: kingthorin <[email protected]>
@kingthorin
Copy link
Member Author

Hopefully that does it.

@thc202
Copy link
Member

thc202 commented Nov 22, 2024

Thank you!

@psiinon do you want to take another look?

@psiinon psiinon merged commit 3ea00b7 into zaproxy:main Nov 22, 2024
10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2024
@kingthorin kingthorin deleted the policies_cd_dev branch November 22, 2024 17:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thc202 thc202 thc202 approved these changes

@psiinon psiinon psiinon approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kingthorin @psiinon @thc202