Skip to content

Commit

Permalink
Deleted the definition of the odt-rpga-feather board which uses a non…
Browse files Browse the repository at this point in the history
… existing programmer. Discussion here FPGAwars#535
  • Loading branch information
zapta committed Jan 14, 2025
1 parent a2f5605 commit ecca2e9
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 20 deletions.
11 changes: 0 additions & 11 deletions apio/resources/boards.jsonc
Original file line number Diff line number Diff line change
Expand Up @@ -667,17 +667,6 @@
"pid": "6014"
}
},
// Candidate for removal.
// See https://github.com/FPGAwars/apio/issues/545
// See https://github.com/FPGAwars/apio/issues/535
"odt-rpga-feather": {
"legacy_name": "ODT_RPGA_Feather",
"description": "ODT_RPGA_Feather",
"fpga": "ice40-u4k-sg48",
"programmer": {
"type": "mcu"
}
},
"colorlight-5a-75b-v61": {
"legacy_name": "ColorLight-5A-75B-V61",
"description": "ColorLight-5A-75B-V61",
Expand Down
2 changes: 1 addition & 1 deletion apio/resources/fpgas.jsonc
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@
"pack": "uwg30"
},
// TODO: Should the part numbrer and type should have 'up' instead of just 'u'?
// This fpga is used by the boards 'odt-icyblue-feather' and 'odt-rpga-feather'.
// This fpga is used by the boards 'odt-icyblue-feather'.
// See https://github.com/FPGAwars/apio/issues/545
// See https://github.com/FPGAwars/apio/issues/535
"ice40-u4k-sg48": {
Expand Down
8 changes: 0 additions & 8 deletions test/test_apio_context.py
Original file line number Diff line number Diff line change
Expand Up @@ -88,10 +88,6 @@ def test_home_dir_with_relative_path(
)


# -- This board is known to be problematic so we skip it.
# -- See https://github.com/FPGAwars/apio/issues/535
KNOWN_BAD_BOARDS = ["odt-rpga-feather"]

# -- These programmers are known to be unused.
# -- https://github.com/FPGAwars/apio/issues/536
KNOWN_UNUSED_PROGRAMMERS = ["ujprog"]
Expand All @@ -109,10 +105,6 @@ def test_resources_references(apio_runner: ApioRunner):
unused_programmers = set(apio_ctx.programmers.keys())

for board_name, board_info in apio_ctx.boards.items():
# -- Skip boards that are known to be problematic.
if board_name in KNOWN_BAD_BOARDS:
continue

# -- Prepare a context message for failing assertions.
board_msg = f"While testing board {board_name}"

Expand Down

0 comments on commit ecca2e9

Please sign in to comment.