feat: server resource packs #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
|
/deploy |
|
Deployed to Vercel Preview: https://prismarine-lieqk4t2x-zaro.vercel.app |
Mqxx
reviewed
Oct 15, 2024
| @@ -58,31 +64,36 @@ export const installTexturePackFromHandle = async () => { | |||
| // await completeTexturePackInstall() | |||
| } | |||
|
|
|||
| export const installTexturePack = async (file: File | ArrayBuffer, displayName = file['name'], name = 'default') => { | |||
| export const installTexturePack = async (file: File | ArrayBuffer, displayName = file['name'], name = 'default', isServer = false) => { | |||
There was a problem hiding this comment.
This could lead to problems. I had the problem that under some conditions the name key inside file was undefined.
Suggested change
| export const installTexturePack = async (file: File | ArrayBuffer, displayName = file['name'], name = 'default', isServer = false) => { | |
| export const installTexturePack = async (file: File | ArrayBuffer, displayName = file['name'] ?? 'default.zip', name = 'default', isServer = false) => { |
There was a problem hiding this comment.
It will be undefined. Display name is not needed after server resource pack is installed as it's not used in the ui, but a good catch, thanks
|
@zardoy can this be merged? |
Yes I think so, I will add models handling in some other pr I think then |
|
@Mqxx did you check that it works on 1.21? |
gguio
pushed a commit
to gguio/prismarine-web-client
that referenced
this pull request
Nov 10, 2024
Co-authored-by: Mqx <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.