Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reapply HDF reader fillvalue #460

Merged
merged 2 commits into from
Mar 3, 2025

Conversation

chuckwondo
Copy link
Contributor

Reapply reverted changes from #420, but with tests modified to use context managers to cleanup resources in an attempt to prevent the build from hanging during unit tests.

@chuckwondo
Copy link
Contributor Author

@TomNicholas, @maxrjones, @sharkinsspatial, I believe this fixes the issue with the hanging unit tests that started when #420 was merged. I have reverted Tom's revert in #457 (thus restoring the origin changes from #420) and have updated related unit tests to use context managers so that file resources are cleaned up, and this appears to have fixed the problem.

Using the origin merge of #420, I was able to periodically (not consistently; perhaps every 3rd attempt) reproduce the hanging test issue locally via act -j test. However, with the changes in this PR, I was unable to reproduce the problem after many attempts. Given that the PR also avoided hanging on the unit tests, I'm fairly confident that making use of context managers was indeed the trick, and that #390 should perhaps be addressed sooner rather than later.

Copy link
Member

@maxrjones maxrjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @chuckwondo!

@maxrjones maxrjones merged commit 1cdc2f0 into zarr-developers:main Mar 3, 2025
9 checks passed
@maxrjones maxrjones mentioned this pull request Mar 3, 2025
@TomNicholas
Copy link
Member

Amazing, thank you @chuckwondo !

@sharkinsspatial
Copy link
Collaborator

Thanks @chuckwondo. 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants