-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Fix v3 spec typo in "operation for retrieving chunk data" section. #296
Conversation
In the core v3 spec, in the `Retrieve chunk data in an array` subsection of the `Storage` section, the operation used to demonstrate retrieval of chunk data is incorrect. It should be `get(data_key(P, j, i, ...))` instead of `get(data_key(P, j, i, ...), value)`.
good catch, thank you @zoj613 |
Btw, I'm currently working on implementing the v3 spec for the Ocaml language so i'm doing a lot of reading. Is there any other resource I can use to make the process a little easier? Maybe those who implemented the spec in other languages have written up about their experience and challenges that I can learn from? |
This is super cool! Since you are probably concerned about having nice types, you may have noticed that while the spec defines metadata documents for groups and arrays, it does not define a data structure / type for a Zarr hierarchy (i.e., a tree of groups + arrays). We attempt to define such a type here: zarr-developers/zeps#46.
I'm not aware of formal writeups, but our regular community meetings often have a mix of implementation authors present (e.g., python and c++, sometimes C and Java). That might be the place to ask, provided the time zone works for you. |
@zoj613: thanks for the fix! Looking forward to seeing your Ocaml work listed on https://zarr.dev/implementations/ 😄 |
@joshmoore @d-v-b Looks like I managed to pull it off quicker than I thought. See this PR: zoj613/zarr-ml#1 Its still a work in progress since I need to still add tests, support concurrent IO, and also squeeze out performance where necessary. |
This is great, @zoj613! Congratulations! Two things:
|
Thanks for the reply. I'd be happy to join one of the community meetings to talk about zarr-ml. I'll see which slot I can choose. In the meantime I opened a PR as you suggested. See: zarr-developers/zarr-developers.github.io#115 |
Thanks, @zoj613! |
In the core v3 spec, in the
Retrieve chunk data in an array
subsection of theStorage
section, the operation used to demonstrate retrieval of chunk data is incorrect. It should beget(data_key(P, j, i, ...))
instead ofget(data_key(P, j, i, ...), value)
.