add zarr-python v3 spec tests cases #52
Conversation
…e top level this is now equivalent in output to the zarrita case, whereas previously we had an 'astronaut' subfolder
|
@joshmoore, could you take a look at the first three commits here in terms of the API for writing the files? In the first commit, I was trying the reuse the same high-level The forms in commits 2 and 3 are equivalent, just using The main issue is that in the current v3 implementation, one cannot create a Group without some for the group. i.e. the group cannot be at just |
There was a problem hiding this comment.
Thanks, @grlee77. Yeah, I imagine anything you struggle with like this also points to issues that users will have, so we will need to engage with it seriously. Not that I have a solution at the moment, so the changes look within reason for the interim.
I've also hit on the desire for a hierarchy class a couple of times. I don't know if now is the time to do it or not (and perhaps just for V3). @constantinpape said something similar when comparing the API to Z5.
| @@ -33,14 +33,15 @@ def generate_zarr_format(compressors=['gzip', 'blosc', 'zlib', None]): | |||
|
|
|||
| nested_str = '_nested' if nested else '_flat' | |||
| path = f'data/zarr_{StoreClass.__name__}{nested_str}.zr' | |||
| zarr_version = StoreClass._store_version | |||
| if zarr_version == 3: | |||
| path = path.replace('.zr', '.zr3') | |||
There was a problem hiding this comment.
Could imagine that we even offer "default file ending" somewhere as a constant.
marked as a draft since this is using a branch corresponding to unmerged upstream PRs
Note that the environment file here installs from the branch corresponding to zarr-developers/zarr-python#898