Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main files in package.json #112

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

darlanmendonca
Copy link

@darlanmendonca darlanmendonca commented Jan 25, 2017

Hello !!

when I install it from npm, I receive the following error

screen shot 2017-01-25 at 10 49 47

as suggestion, following the npm package specs, the key main need be a string, not a array, e.g.

{
  "main": "dist/material-design-iconic-font.css"
}

an, how you have other files, like fonts to be used, I suggest use another key from package to say that, I believe the right key is files, package doc says 'The "files" field is an array of files to include in your project'

So, in my PR, I commit the following

{
  "main": "dist/css/material-design-iconic-font.css",
  "files": [
    "dist/css/material-design-iconic-font.css",
    "dist/fonts"
  ]
}

What you think?

@darlanmendonca darlanmendonca changed the title adjust files in package json, and unique file in main Main file in package.json Jan 25, 2017
@darlanmendonca darlanmendonca changed the title Main file in package.json Main filse in package.json Jan 25, 2017
@darlanmendonca darlanmendonca changed the title Main filse in package.json Main files in package.json Jan 25, 2017
@trickeyone
Copy link

Yeah, I ran into the same thing. Submitted a pull request (#109) back in November. I don't think this project is maintained any longer.

@darlanmendonca
Copy link
Author

😞

@david-duncan
Copy link

@zavoloklom this is low hanging fruit to merge and close #109

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants