Update to Stock Quote History v8 #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new API version enables getting a stock quote history directly from the browser, by just typing some URL such as below: https://query1.finance.yahoo.com/v8/finance/chart/MGLU3.sa?period1=1575158400&period2=1575504000&interval=1d&events=history&crumb=VzVqQTpsL8n That makes it easier to check results, since there is no need to deal with cookies.
- Updates morpheus-viz to 0.9.21 since version 0.9.16 is not available at Maven Central. - Bump morpheus-yahoo version.
of them, all the results got from the other stocks were being discarded. Now, if a request for one stock fails, successful response are accordingly concatenated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to the new Stock Quote History v8 API
The new API version enables getting a stock quote history directly from the browser, by just typing some URL such as this one.
That makes it easier to check results, since there is no need to deal with cookies.
Some tests are failing because the version 7 of the API is returning slightly different values than version 8. Those results are stored in files at src/test/resources/quotes/, which are used for tests.
Fix Multiple Stocks Request
When multiple stocks are provided and the query fails for one of them, all the results got from the other stocks were being
discarded. Now, if a request for one stock fails, successful response are accordingly concatenated.