refactor: comment + call this.finish()

zazuko · Sep 19, 2024 · 3af39ff · 3af39ff
1 parent 05e4109
commit 3af39ff
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/packages/core/lib/Pipeline.ts b/packages/core/lib/Pipeline.ts
@@ -117,8 +117,11 @@ class Pipeline extends StreamObject<Stream & { pipeline?: Pipeline }> {
       }
 
       this.lastChild.stream.on('end', () => {
+        // in some cases, a duplex stream emits the end event but is still writable
+        // which prevents the pipeline from reaching the finished callback below
+        // in such case, a pipeline never finishes, and the process hangs
         if (!isWritable(this.lastChild.stream) && !isReadable(this.lastChild.stream)) {
-          this.lastChild.stream.emit('finish')
+          this.finish()
         }
       })