feat(shared-dimension): contributors

[tpluscode]

No description provided.

[changeset-bot]

🦋 Changeset detected

Latest commit: fd6bba2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@cube-creator/shared-dimensions-api	Patch
@cube-creator/core-api	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[tpluscode]

I was surprised to discover that the shared dimensions and hierarchies were both handled by the "resource" handler which was in fact specific to shared dimensions. I moved that to its own module and simplified the generic one

[codecov]

Codecov Report

Attention: Patch coverage is 58.22785% with 33 lines in your changes missing coverage. Please review.

Project coverage is 74.01%. Comparing base (e6a43dc) to head (fd6bba2).
Report is 5 commits behind head on master.

Files with missing lines	Patch %	Lines
...shared-dimensions/lib/handlers/shared-dimension.ts	0.00%	23 Missing ⚠️
apis/core/lib/auth.ts	0.00%	5 Missing ⚠️
apis/shared-dimensions/lib/handlers/resource.ts	0.00%	4 Missing ⚠️
...hared-dimensions/lib/handlers/shared-dimensions.ts	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1556      +/-   ##
==========================================
+ Coverage   73.99%   74.01%   +0.02%     
==========================================
  Files         222      222              
  Lines       15093    15149      +56     
  Branches      891      895       +4     
==========================================
+ Hits        11168    11213      +45     
- Misses       3917     3928      +11     
  Partials        8        8              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[giacomociti]

I just wonder if the list of contributors can be shown with a consistent sorting (alphabetical, temporal). Apparently it's quite random

[tpluscode]

Interesting question. Shaperone uses sh:order to sort the properties but I IIRC there is no inherent order applied to the values themselves. Since the contributors are blank nodes, there isn't any default ordering either.

SHACL-AF has an ordering node expression but it's not exactly applicable here