Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: shsh namespace base URL #184

Merged
merged 2 commits into from
Dec 8, 2023
Merged

fix: shsh namespace base URL #184

merged 2 commits into from
Dec 8, 2023

Conversation

tpluscode
Copy link
Contributor

No description provided.

Copy link

changeset-bot bot commented Dec 7, 2023

🦋 Changeset detected

Latest commit: 692f847

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@vocabulary/shsh Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 7, 2023

Did you remember to add changeset to @zazuko/prefixes?


Automated comment created by PR Commenter 🤖.

@codecov-commenter
Copy link

codecov-commenter commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (868b751) 95.66% compared to head (692f847) 95.66%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #184   +/-   ##
=======================================
  Coverage   95.66%   95.66%           
=======================================
  Files           7        7           
  Lines         277      277           
  Branches       22       22           
=======================================
  Hits          265      265           
  Misses         12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ludovicm67 ludovicm67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "Build changed" needs to be fixed before we merge this PR.

The change of the prefix LGTM.

@tpluscode tpluscode force-pushed the shsh-http branch 3 times, most recently from 5081f68 to a8fa51f Compare December 7, 2023 20:30
Copy link
Member

@ludovicm67 ludovicm67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we also upgrade some GitHub Actions.

Regarding the Build changed GitHub Actions step you introduced, if it's too complicated to have it working, I suggest we extract this in a dedicated PR, so that we can already trigger a new release for the shsh vocabulary package that contains the fix for the namespace.

.github/workflows/node.js.yaml Outdated Show resolved Hide resolved
.github/workflows/node.js.yaml Outdated Show resolved Hide resolved
@tpluscode tpluscode merged commit 769d175 into master Dec 8, 2023
5 checks passed
@tpluscode tpluscode deleted the shsh-http branch December 8, 2023 10:08
@github-actions github-actions bot mentioned this pull request Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants