-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: shsh namespace base URL #184
Conversation
🦋 Changeset detectedLatest commit: 692f847 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Did you remember to add changeset to Automated comment created by PR Commenter 🤖. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #184 +/- ##
=======================================
Coverage 95.66% 95.66%
=======================================
Files 7 7
Lines 277 277
Branches 22 22
=======================================
Hits 265 265
Misses 12 12 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "Build changed" needs to be fixed before we merge this PR.
The change of the prefix LGTM.
5081f68
to
a8fa51f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest we also upgrade some GitHub Actions.
Regarding the Build changed
GitHub Actions step you introduced, if it's too complicated to have it working, I suggest we extract this in a dedicated PR, so that we can already trigger a new release for the shsh
vocabulary package that contains the fix for the namespace.
No description provided.