zcash_client_sqlite: Assign UUIDs to each account

[str4d]

This provides equivalent uniqueness to the accounts table primary key, but avoids collisions across wallet recreation events (to defend against downstream crate users who don't flush any persisted account IDs at those events).

Closes #1629.

[codecov]

Codecov Report

Attention: Patch coverage is 72.94833% with 89 lines in your changes missing coverage. Please review.

Project coverage is 56.41%. Comparing base (2df4497) to head (6e1933b).

Files with missing lines	Patch %	Lines
zcash_client_sqlite/src/wallet.rs	71.30%	33 Missing ⚠️
...e/src/wallet/init/migrations/tx_retrieval_queue.rs	56.86%	22 Missing ⚠️
zcash_client_sqlite/src/wallet/transparent.rs	64.70%	12 Missing ⚠️
zcash_client_sqlite/src/lib.rs	61.11%	7 Missing ⚠️
...te/src/wallet/init/migrations/add_account_uuids.rs	92.18%	5 Missing ⚠️
zcash_client_sqlite/src/wallet/orchard.rs	0.00%	5 Missing ⚠️
zcash_client_sqlite/src/error.rs	0.00%	1 Missing ⚠️
zcash_client_sqlite/src/wallet/common.rs	83.33%	1 Missing ⚠️
.../src/wallet/init/migrations/ephemeral_addresses.rs	80.00%	1 Missing ⚠️
zcash_client_sqlite/src/wallet/sapling.rs	85.71%	1 Missing ⚠️
... and 1 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1631      +/-   ##
==========================================
+ Coverage   56.39%   56.41%   +0.02%     
==========================================
  Files         148      149       +1     
  Lines       19232    19404     +172     
==========================================
+ Hits        10845    10947     +102     
- Misses       8387     8457      +70     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[str4d]

I discovered that the Android SDK is misusing v_tx_outputs by putting to_account_id into a type that actually stores a ZIP 32 account index. These previously were indeed the same type, until #1235 was merged. I think we need to alter the views to expose the account UUIDs instead of the account IDs, particularly as after this PR the account IDs cannot be extracted from AccountId and are intended to be entirely internal.

[daira]

utACK with comments.

[str4d]

Force-pushed to replace account_id in the views with account_uuid (because account_id is now intended to be an internal-only value). cc @AArnott for awareness (though I've also documented it in the changelogs).

[daira]

utACK with this suggestion: https://github.com/zcash/librustzcash/pull/1631/files#r1855319372

[nuttycom]

If we're going to make this change, we should do so wholesale: replace the contents of the AccountId type with the UUID, and change all the queries to take the UUID (and join to the accounts table if necessary).

[nuttycom]

This change is necessary because we get new account UUIDs when we regenerate the wallet.