Convert hyphen in tree-sitter grammar name to underscore #25881
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`compile_grammar()` in `extension_builder.rs` passes the name of the Tree-sitter grammar directly to `ld` as a symbol to be exported. But C does not allow hyphens in symbol names. This is a work-in-progress since I haven't been able to find where the symbol is imported yet. My Tree-sitter grammar is here: https://github.com/hippietrail/tree-sitter-harper-dict
cla-bot
bot
added
the
cla-signed
hippietrail
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Notes:
compile_grammar()inextension_builder.rspasses the name of the Tree-sitter grammar directly toldas a symbol to be exported. But C does not allow hyphens in symbol names.This is a work-in-progress since I haven't been able to find where the symbol is imported yet.
My Tree-sitter grammar is here: https://github.com/hippietrail/tree-sitter-harper-dict
See the discussion I started before digging into the code: #25847