Disconnect slow peers and WS clients by default #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neverlord
force-pushed
the
issue/gh-426
branch
2 times, most recently
from
203ecce to
215b898
Compare
ckreibich
force-pushed
the
issue/gh-426
branch
from
bae3228 to
f848eb4
Compare
ckreibich
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
This all looks good to me Dominik. I'm sorry to have left this sitting for so long — I've been working with this branch throughout and am about to open a follow-up PR with a few tweaks, but let me merge this next. (I only rebased to bring the changes back to the top.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new maximum buffer size of peers and WebSocket clients. When reaching that limit, Broker will automatically sever the connection by default. Alternatively, users may select a DropOldest or DropNewest policy. Buffer sizes are configurable as well.