Require Python 3.9 #439
Merged
Require Python 3.9 #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timwoj
force-pushed
the
topic/timw/python-upgrade
branch
from
d69801f to
169e04b
Compare
ckreibich
approved these changes
Dec 6, 2024
timwoj
force-pushed
the
topic/timw/python-upgrade
branch
from
169e04b to
61c08da
Compare
I added the same @Neverlord Could you look at the couple of TODOs I added in 9ad0642? There's some questions I had about a couple of the tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ubuntu's python packages are weird. If you just install
python3.9andpython3.9-devit doesn't install all of the files needed for CMake to figure out where/usr/lib/python3/dist-packagesis. You have to at least installpython3-distutils. This ends up installingpython3so that's fine to. It's all really stupid.