Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI Updates #440

Merged
merged 3 commits into from
Dec 13, 2024
Merged

CI Updates #440

merged 3 commits into from
Dec 13, 2024

Conversation

timwoj
Copy link
Member

@timwoj timwoj commented Dec 13, 2024

This fixes some build issues with recent updates:

  • opensuse-leap VMs were still using old versions of gcc, so the recent cmake change to enforce newer compiler versions broke the CI builds. This PR aligns it with what we're installing on Zeek's images.
  • ubuntu 20 was missing some necessary python3 files for configure to be able to find the dist-packages directory.

@timwoj timwoj requested a review from ckreibich December 13, 2024 17:58
@timwoj timwoj force-pushed the topic/timw/ci-compiler-updates branch from aa4057f to 6bb14a1 Compare December 13, 2024 18:05
ckreibich
ckreibich approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@ckreibich ckreibich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. 15.5 really does still give you Python 3.6 by default, even after running zypper up.

Btw 15.5 EOLs at the end of the month ... but we probably don't want to go through everything right now to ditch it. :-)

@timwoj timwoj merged commit 5847b2a into master Dec 13, 2024
19 of 20 checks passed
@timwoj timwoj deleted the topic/timw/ci-compiler-updates branch December 13, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckreibich ckreibich ckreibich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timwoj @ckreibich