Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spicy_add_analyzer: Depend on CXX_LINK arg #103

Merged

Conversation

awelzel
Copy link
Contributor

@awelzel awelzel commented Jan 5, 2024

In the spicy-quic project it was found that the quic.hlto wasn't being rebuilt/relinked when the libdecrypt_crypto.a library changed. @bbannier hinted at a missing dependency on the CXX_LINK argument for the custom command invoking spicyz.

In the spicy-quic project it was found that the quic.hlto wasn't being
rebuilt/relinked when the libdecrypt_crypto.a library changed. @bbannier
hinted at a missing dependency on the CXX_LINK argument for the custom
command invoking spicyz.
@awelzel awelzel requested a review from bbannier January 5, 2024 10:31
Copy link
Member

@bbannier bbannier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🚀

@awelzel awelzel merged commit 82b1c81 into master Jan 5, 2024
1 check passed
@awelzel awelzel deleted the topic/awelzel/spicy-analyzer-support-cxx-link-depends branch January 5, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants