spicy_add_analyzer: Do not use SCRIPTS #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SCRIPTS parameter for spicy_add_analyzer() is not functional, so rendering it into CMakeLists.txt is confusing [1]. Remove it. These scripts are installed via zkg.meta's script_dir here in the template. [1] zeek/cmake#97
|
The CMakeLists.txt is also reused for packet and file analyzers which don't have dpd.sig anyhow. |
bbannier
approved these changes
Jun 19, 2024
There was a problem hiding this comment.
Since this is completely ignored for now this makes sense to me. Not sure about completely removing support for it e.g., by raising deprecation diagnostics or warnings though since it might still offer a convenient API to hook in this functionality in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SCRIPTS parameter for spicy_add_analyzer() is not functional, so rendering it into CMakeLists.txt is confusing [1]. Remove it.
These scripts are installed via zkg.meta's script_dir here in the template.
[1] zeek/cmake#97