Add initial CI

[bbannier]

Closes #4.

[bbannier]

This PR is in principle ready for a first review. It provides tests for template features (either by running a full build & test, or with smoke tests), and a pre-commit config for linting (when a linter required fixes to existing sources I tried to put that in its own commit). The CI runs in GH which is probably okay since it should finish quickly.

It should probably still go in after #2 so I can add additional tests and make linter fixes.

Interesting bits:

• CI does not work with zeek-5.0.0 since its packaged zkg does not support the create command which we need for testing the template; provide CI only for latest version for now
• since we likely run multiple zkg create operations concurrently, we need to provide a workaround for Concurrent zkg create operations can race on update of default package source package-manager#139.
• pylint configuration was moved into a .pylintrc file

[bbannier]

I rebased this onto the latest master and rewrote the recently merged Spicy feature tests into btests. Would be great if you could have a look @ckreibich @rsmmr.

[bbannier]

While figuring out how to make this work against a nightly Zeek I noticed that the new zkg wrapper introduced additional issues (filed zeek/package-manager#144 and added a workaround; fixed GH execution for zeek/package-manager#145).

[ckreibich]

Looking great, thank you! I only have some minor requests (though see that black comment).

The only hiccup is that when I run this locally (with Zeek 5.2.0-dev.51), the features.spicy-packet-analyzer test errors with:

[#1] tests.availability ... ok
[#2] tests.trace ... failed
  % 'zeek -Cr ${TRACES}/raw-layer.pcap ${PACKAGE} /home/christian/devel/zeek/package-template/tests/.tmp/features.spicy-packet-analyzer/test/testing/.tmp/tests.trace/trace.zeek >output' failed unexpectedly (exit code 1)
  % cat .stderr
  error in /home/christian/devel/zeek/package-template/tests/.tmp/features.spicy-packet-analyzer/test/testing/../scripts/./main.zeek, line 12: unknown identifier PacketAnalyzer::ANALYZER_SPICY_MYANALYZER957136, at or near "PacketAnalyzer::ANALYZER_SPICY_MYANALYZER957136"

1 of 2 tests failed

I'll look into that a bit since I'm noticing it's not failing in CI. Probably just something silly on my machine.

[bbannier]

The only hiccup is that when I run this locally (with Zeek 5.2.0-dev.51), the features.spicy-packet-analyzer test errors with: ...

I added some Zeek preprocessor branch to the Spicy packet analyzer template which branches on versions before or after 5.2.0, but your dev snapshot seems to be from before that branch. Somewhere on the 5.2 dev branch I bumped a spicy-plugin change from Robin removes double underscores from packet analyzer names, but your snapshot seems to miss that.

[ckreibich]

Yeah Benjamin it all works now over here too. Thanks!